Skip to content

Fixes SQL query when DISABLE_MOB_NPC_CHAR_NAMES is true#7451

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
overefined:disable_mob_npc_char_names
Apr 19, 2025
Merged

Fixes SQL query when DISABLE_MOB_NPC_CHAR_NAMES is true#7451
zach2good merged 1 commit intoLandSandBoat:basefrom
overefined:disable_mob_npc_char_names

Conversation

@overefined
Copy link
Copy Markdown
Contributor

@overefined overefined commented Apr 19, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Removes unsupported CTE from SQL query when creating a character with DISABLE_MOB_NPC_CHAR_NAMES set to true

Closes: #7391

Steps to test these changes

login.lua
DISABLE_MOB_NPC_CHAR_NAMES = true

create a new character

@overefined overefined force-pushed the disable_mob_npc_char_names branch from 5901a4b to 3850e5c Compare April 19, 2025 01:41
@overefined overefined changed the title Remove unsupported CTE from SQL query Fixes SQL query when DISABLE_MOB_NPC_CHAR_NAMES is true Apr 19, 2025
@zach2good zach2good merged commit f917734 into LandSandBoat:base Apr 19, 2025
13 checks passed
@overefined overefined deleted the disable_mob_npc_char_names branch April 19, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Character creation with DISABLE_MOB_NPC_CHAR_NAMES = true returns SQL error

2 participants