Skip to content

[Fix] Coronach Aftermath#7454

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Rosienaikanaro:Coronach_Aftermath_Fix
Apr 20, 2025
Merged

[Fix] Coronach Aftermath#7454
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Rosienaikanaro:Coronach_Aftermath_Fix

Conversation

@Rosienaikanaro
Copy link
Copy Markdown
Contributor

@Rosienaikanaro Rosienaikanaro commented Apr 19, 2025

Coronach now grants aftermath even on a zero damage hit or a miss.

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Coronach should grant aftermath even on a miss or zero damage hit.

Steps to test these changes

!changejob rng 75
!additem 18336 (Annihilator)
!additem 17343 (Bronze Bullet)
!tp 3000
Fire at any mob without already having aftermath, miss should grant AM.

Retail Capture

Coronach miss still grants AM - Video Proof
Coronach miss still grants AM - Capture Data

Coronach now grants aftermath even on a zero damage hit or a miss.
@Xaver-DaRed
Copy link
Copy Markdown
Contributor

Please provide a link for the capture itself, not a link for a discord. No1 should be clicking random discord links, after all.

@Xaver-DaRed Xaver-DaRed changed the title Coronach_Aftermath_Fix [Fix] Coronach Aftermath Apr 20, 2025
@Xaver-DaRed Xaver-DaRed merged commit 881264a into LandSandBoat:base Apr 20, 2025
14 checks passed
@Rosienaikanaro Rosienaikanaro deleted the Coronach_Aftermath_Fix branch November 21, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants