Remove PChar from zone on force logout#7459
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom Apr 20, 2025
Merged
Conversation
Xaver-DaRed
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Steps to reproduce:
This change ensures we remove the PChar from their zone when going through any
ForceLogoutcall, such as when GMs logout.server/src/map/packet_system.cpp
Lines 5848 to 5852 in 491498a
Before #7243,
removeCharFromZonewas always called (when everything was going throughSendToZone), this merely reintroduces parity.server/src/map/utils/charutils.cpp
Lines 6528 to 6588 in 8f65f3c
Closes #7390
Steps to test these changes
Login/logout as GM, see session gets cleaned up immediately