Skip to content

Separate Steal and Despoil lockout#7488

Merged
Xaver-DaRed merged 3 commits intoLandSandBoat:basefrom
wccbuck:separate_steal_and_despoil_lockout
Apr 25, 2025
Merged

Separate Steal and Despoil lockout#7488
Xaver-DaRed merged 3 commits intoLandSandBoat:basefrom
wccbuck:separate_steal_and_despoil_lockout

Conversation

@wccbuck
Copy link
Copy Markdown
Contributor

@wccbuck wccbuck commented Apr 25, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This change resolves #7352, creating a separate "isDespoiled" tracker for despoiled items versus stolen ones. Now you can steal and despoil from the same mob.

Steps to test these changes

!changejob THF 99

!exec player:setMod(xi.mod.STEAL, 50)
!exec player:setMod(xi.mod.DESPOIL, 50)

Find some goblins in labyrinth of onzozo and try stealing and despoiling; you should be able to get two items.

@Xaver-DaRed Xaver-DaRed added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Apr 25, 2025
@wccbuck wccbuck force-pushed the separate_steal_and_despoil_lockout branch from 3bf6e86 to 4c674a8 Compare April 25, 2025 19:17
@Xaver-DaRed Xaver-DaRed removed the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Apr 25, 2025
@Xaver-DaRed Xaver-DaRed merged commit 6969062 into LandSandBoat:base Apr 25, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔨 Separate Despoil and Steal lockout

3 participants