Skip to content

[fix] CLinkshell::ChangeMemberRank crash#7489

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:ls_crash_fix
Apr 25, 2025
Merged

[fix] CLinkshell::ChangeMemberRank crash#7489
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:ls_crash_fix

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 25, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

When promoting a linkpearl to a sack, the original linkpearl is destroyed and then accessed by the subsequent query which causes the map server to crash inconditionally.

Line was removed in #7322

Steps to test these changes

  • Give pearl to 2nd char
  • Promote pearl to sack
  • No crash

@zach2good zach2good merged commit 16d8017 into LandSandBoat:base Apr 25, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants