Add six new item mod IDs#7516
Conversation
|
We don't usually allow adding random modifier IDs without them being actually implemented. I would propose this new, non-implemented, modifiers to be all placed at the end of the list, under a comment that states |
That's fair. To give context, I am intending on adding functionality to all of these item mods over the next week, and decided to make this PR first in order to prevent a mod ID conflict which has happened before. Would it be sufficient for me to replace my "// TODO" with "// NOT YET IMPLEMENTED" on each of these? |
-- TODO: this mods are not implemented.
MOD_NAME_1 = n1
MOD_NAME_2 = n2
...Then once you (or whoever else) decide to implement any of them, they can be moved to a better place. Just a matter of organizing stuff properly, to make it clear not for a select few, but for as many ppl as possible within reason |
8c0699c to
daaa887
Compare
I affirm:
What does this pull request do?
This PR adds, but does not yet implement, the following item IDs, and assigns them to appropriate gear:
In addition, this PR fixes two bugs I noticed while implementing these changes. Namely:
Steps to test these changes
The new item mods aren't hooked up yet so no real way to test those, but you can confirm that ninja MAB gear is now working by performing a ninja nuke with and without Koga Hatsuburi equipped.