[lua] Implement ENHANCES_ELEMENTAL_SEAL#7520
Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom May 2, 2025
Merged
Conversation
Xaver-DaRed
reviewed
May 2, 2025
Xaver-DaRed
reviewed
May 2, 2025
2963eeb to
09f4002
Compare
Xaver-DaRed
reviewed
May 2, 2025
09f4002 to
535a851
Compare
Xaver-DaRed
approved these changes
May 2, 2025
Xaver-DaRed
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Implements the item mod ENHANCES_ELEMENTAL_SEAL, seen on the mythic weapon Laevateinn, which adds bonus damage to elemental spells cast under the effect of Elemental Seal.
Steps to test these changes
!changejob BLM 99
!additem 18994 (laevateinn lv75, ele seal +10)
Put a print statement in xi.spells.damage.calculateEleSealMultiplier for eleSealMultiplier. When casting a nuke without Laevateinn equipped, with or without Elemental Seal active, the multiplier should be 1. With Laevateinn equipped and Elemental Seal active, the multiplier should be 1.1.