Skip to content

[lua] Implement ENHANCES_ELEMENTAL_SEAL#7520

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
wccbuck:implement_enhance_ele_seal
May 2, 2025
Merged

[lua] Implement ENHANCES_ELEMENTAL_SEAL#7520
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
wccbuck:implement_enhance_ele_seal

Conversation

@wccbuck
Copy link
Copy Markdown
Contributor

@wccbuck wccbuck commented May 2, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements the item mod ENHANCES_ELEMENTAL_SEAL, seen on the mythic weapon Laevateinn, which adds bonus damage to elemental spells cast under the effect of Elemental Seal.

Steps to test these changes

!changejob BLM 99
!additem 18994 (laevateinn lv75, ele seal +10)

Put a print statement in xi.spells.damage.calculateEleSealMultiplier for eleSealMultiplier. When casting a nuke without Laevateinn equipped, with or without Elemental Seal active, the multiplier should be 1. With Laevateinn equipped and Elemental Seal active, the multiplier should be 1.1.

Comment thread scripts/globals/spells/damage_spell.lua Outdated
Comment thread scripts/globals/spells/damage_spell.lua
@wccbuck wccbuck force-pushed the implement_enhance_ele_seal branch from 2963eeb to 09f4002 Compare May 2, 2025 14:56
Comment thread scripts/globals/spells/damage_spell.lua Outdated
@wccbuck wccbuck force-pushed the implement_enhance_ele_seal branch from 09f4002 to 535a851 Compare May 2, 2025 15:04
@Xaver-DaRed Xaver-DaRed merged commit cf01a0e into LandSandBoat:base May 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants