Skip to content

[Chore] Fix duplicate modifier id and minor weaponskill cleanup#7530

Merged
zach2good merged 2 commits intoLandSandBoat:basefrom
Xaver-DaRed:more-cleanup
May 6, 2025
Merged

[Chore] Fix duplicate modifier id and minor weaponskill cleanup#7530
zach2good merged 2 commits intoLandSandBoat:basefrom
Xaver-DaRed:more-cleanup

Conversation

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Fixed case where 2 modifiers shared 1 id (141)
  • Retired old weaponskill function with newer and better one.

Steps to test these changes

None.

@zach2good zach2good merged commit feec03f into LandSandBoat:base May 6, 2025
24 of 25 checks passed
@Xaver-DaRed Xaver-DaRed deleted the more-cleanup branch May 6, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants