Skip to content

[sql] Dirge/Sirvente AoE songs#7535

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:dirge_sirvente_aoe
May 7, 2025
Merged

[sql] Dirge/Sirvente AoE songs#7535
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:dirge_sirvente_aoe

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented May 7, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Make Adventurer's Dirge and Foe Sirvente songs AoE type 5 (AoE affected by Pianissimo)
Also changes the validTargets from

TARGET_SELF
TARGET_PLAYER_PARTY

to

TARGET_SELF
TARGET_PLAYER_PARTY_PIANISSIMO

Adventurer's_Dirge_(Scroll)_description

Foe_Sirvente_(Scroll)_description

Steps to test these changes

!changejob BRD 99
!addallspells

Sing them with another PC. See it affects both.

image

@sruon sruon force-pushed the dirge_sirvente_aoe branch from 43b4b3f to 55eb782 Compare May 7, 2025 04:21
@Xaver-DaRed Xaver-DaRed merged commit a0c2808 into LandSandBoat:base May 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants