[fix] Always save unlocked PUP attachments#7539
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom May 11, 2025
Merged
Conversation
Xaver-DaRed
approved these changes
May 10, 2025
zach2good
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
With some of the recent PUP changes, the query to save newly unlocked attachments was gated behind a main/sub job check for PUP, but that does not work for two reasons:
This PR splits the saving of unlocked attachments and equipped attachments in two different functions.
There was also a small issue in the Automaton name query, which led to the returned automaton name to be empty when queried from lua.
Steps to test these changes