Skip to content

[fix] Always save unlocked PUP attachments#7539

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:pup_attachments_fix
May 11, 2025
Merged

[fix] Always save unlocked PUP attachments#7539
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:pup_attachments_fix

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented May 8, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

With some of the recent PUP changes, the query to save newly unlocked attachments was gated behind a main/sub job check for PUP, but that does not work for two reasons:

  • When you unlock PUP, you are on another job. Therefore the default unlocked frames Harlequin Frame and Head are not saved on quest completion.
    • There is a fallback in the LoadAutomaton part of the code to force equip them if no frame/head are found, but that stops working as soon as you equip any other unlocked frame/head, and then the Harlequin pieces are gone forever.
  • Tateeya accepts attachments trades on any job
    • This leads to Tateeya eating the item but not unlocking it.

This PR splits the saving of unlocked attachments and equipped attachments in two different functions.

There was also a small issue in the Automaton name query, which led to the returned automaton name to be empty when queried from lua.

Steps to test these changes

  • Complete "No Strings Attached" to unlock PUP, verify Harlequin Frame and Harlequin Head show up in your list of attachments (and not just equipped)
  • Trade Tateeya attachments as non-PUP and check as PUP that they were saved

@zach2good zach2good merged commit e3fb344 into LandSandBoat:base May 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants