[fix] AH Announcements, AH timer issue#7540
Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom May 11, 2025
Merged
Conversation
Contributor
|
Oh good catch. Could also use Edit: or |
Contributor
Author
|
Made the change based on your recommendation since that's easier to read and understand. |
Xaver-DaRed
approved these changes
May 10, 2025
zach2good
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
2 for 1
Reworks ah_announcement module to defer the bulk of the logic to auctionutils, so it stops breaking every other day. Closes 🐛 AH announcements module not letting purchases proceed #7485
Fixes the check for user throttling when they check list of sales, as it is currently defaulting to the "Try again later" state
m_AHHistoryTimestampis initialized totimer::time_point::min()(min value of a long long), the existing check no longer works.Steps to test these changes
Without modules enabled:
With modules enabled: