[LUA] xi.shop.general stock table formatting

[MowFord]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Continuation of #7518

Updates the shop.lua functions to utilize a proper table of shop items

• xi.shop.general updated
  • affected pretty much any normal npc vendor, there are 5 commits group all the zone letters to ~40 file edits each
• that function is also used in the following:
  • xi.shop.outpost
    • self-contained
  • xi.shop.celebratory
    • self-contained
  • xi.shop.nation
    • Sparked a ton of NPCs that utilize this function

All-in-all the change is very simple, and mangling the table causes the map server to complain:

So I'm pretty confident the updates are sane and work as expected (I have of course spot checked quite a few NPCs).

I fully expect CICD to find some tables with formatting it doesn't like. I'll take care of that tomorrow or Monday.

Steps to test these changes

Travel the world and window shop at basically every vendor NPC

• !zone <blah>
• !gotoname <blah>