Manage CCharEntity::PJobPoints with unique_ptr#7690
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom Jul 11, 2025
Merged
Manage CCharEntity::PJobPoints with unique_ptr#7690zach2good merged 1 commit intoLandSandBoat:basefrom
zach2good merged 1 commit intoLandSandBoat:basefrom
Conversation
PJobPoints: Contributes to LandSandBoat#5171 by converting PJobPoints raw pointer to unique_ptr.
4 tasks
zach2good
approved these changes
Jul 11, 2025
claybie
pushed a commit
to claybie/LeafSpringCog
that referenced
this pull request
Aug 11, 2025
Manage CCharEntity::PJobPoints with unique_ptr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
(Second attempt, first attempt was #7683) PJobPoints: Contributes to #5171 by converting PJobPoints raw pointer to unique_ptr.
Steps to test these changes
Test1: Gave a test character job points and added JP abilities.
Test2: Logged in and out of the server several times.