Skip to content

C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]#7740

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:c2s_val_12
Jul 23, 2025
Merged

C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]#7740
zach2good merged 1 commit intoLandSandBoat:basefrom
sruon:c2s_val_12

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Jul 23, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Last PR of first phase with all remaining packets.

Noteworthy:

  • Enables Adoulin MH exits (always available, no quest)
  • ACTION (Dismount): Removed workaround introduced in Fix Dismounting sometimes causing players to become invisible #2515 as it was resolved in Proper mounts rendering, Noble Chocobo fix, Kraklaw mount #7716
  • ACTION (CastMagic): Clamped luopan offsets to [-19, 19] - this isn't the proper fix, the magic AI needs to be updated to account for offsets
  • ACTION (ChocoboDig): Restricted digging to rented and personal chocobos.
  • PBX (Delivery Box): Moved the dboxutils packet handler up to the actual packet. Added a lot of checks.
  • 0x112: No longer sends RoE records and is instead flagged as not implemented.
    • The RoE records are sent instead as a response to 0x00f CLSTAT like just about every other chunk of data. Retail sends that data in between Missions and Spells so CLSTAT is the right place.
    • Still trying to figure out the exact effect of this packet

Steps to test these changes

  • GP_CLI_COMMAND_CLSTAT (sends RoE packets)
  • GP_CLI_COMMAND_ACTION Talk
  • GP_CLI_COMMAND_ACTION Attack
  • GP_CLI_COMMAND_ACTION CastMagic
  • GP_CLI_COMMAND_ACTION AttackOff
  • GP_CLI_COMMAND_ACTION Help
  • GP_CLI_COMMAND_ACTION Weaponskill
  • GP_CLI_COMMAND_ACTION JobAbility
  • GP_CLI_COMMAND_ACTION HomepointMenu
  • GP_CLI_COMMAND_ACTION Assist
  • GP_CLI_COMMAND_ACTION RaiseMenu
  • GP_CLI_COMMAND_ACTION Fish
  • GP_CLI_COMMAND_ACTION ChangeTarget
  • GP_CLI_COMMAND_ACTION Shoot
  • GP_CLI_COMMAND_ACTION ChocoboDig
  • GP_CLI_COMMAND_ACTION Dismount
  • GP_CLI_COMMAND_ACTION TractorMenu
  • GP_CLI_COMMAND_ACTION SendResRdy
  • GP_CLI_COMMAND_ACTION Blockaid
  • GP_CLI_COMMAND_ACTION MonsterSkill (MON abilities look like they don't work but it's similar on base)
  • GP_CLI_COMMAND_ACTION Mount
  • GP_CLI_COMMAND_FRAGMENTS Server message
  • GP_CLI_COMMAND_FRAGMENTS Fish ranking
  • GP_CLI_COMMAND_PBX
  • GP_CLI_COMMAND_EQUIP_SET
  • GP_CLI_COMMAND_EQUIPSET_SET
  • GP_CLI_COMMAND_EQUIPSET_CHECK
  • GP_CLI_COMMAND_LOCKSTYLE
  • GP_CLI_COMMAND_MAPRECT
  • GP_CLI_COMMAND_GROUP_SOLICIT_REQ
  • GP_CLI_COMMAND_GROUP_LEAVE
  • GP_CLI_COMMAND_GROUP_BREAKUP
  • GP_CLI_COMMAND_GROUP_STRIKE
  • GP_CLI_COMMAND_GROUP_SOLICIT_RES
  • GP_CLI_COMMAND_GROUP_CHANGE2
  • GP_CLI_COMMAND_BATTLEFIELD_REQ

Co-Authored-By: atom0s <atom0s@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work as always

uint32_t UniqueNo; // PS2: UniqueNo
uint16_t ActIndex; // PS2: ActIndex
uint16_t ActionID; // PS2: ActionID
union {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future I'd like to get rid of our usage of unions, but for now it's fine. We'd want to use std::variant or xi::variant, if they're around, since accessing a non-defined member of a union is UB (even though that's the common use case)

@zach2good zach2good merged commit e69bbd8 into LandSandBoat:base Jul 23, 2025
14 checks passed
@sruon sruon deleted the c2s_val_12 branch July 23, 2025 19:39
claybie pushed a commit to claybie/LeafSpringCog that referenced this pull request Aug 11, 2025
C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants