C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]#7740
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom Jul 23, 2025
Merged
C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]#7740zach2good merged 1 commit intoLandSandBoat:basefrom
zach2good merged 1 commit intoLandSandBoat:basefrom
Conversation
Co-Authored-By: atom0s <atom0s@users.noreply.github.com>
zach2good
approved these changes
Jul 23, 2025
Contributor
zach2good
left a comment
There was a problem hiding this comment.
Excellent work as always
| uint32_t UniqueNo; // PS2: UniqueNo | ||
| uint16_t ActIndex; // PS2: ActIndex | ||
| uint16_t ActionID; // PS2: ActionID | ||
| union { |
Contributor
There was a problem hiding this comment.
In the future I'd like to get rid of our usage of unions, but for now it's fine. We'd want to use std::variant or xi::variant, if they're around, since accessing a non-defined member of a union is UB (even though that's the common use case)
claybie
pushed a commit
to claybie/LeafSpringCog
that referenced
this pull request
Aug 11, 2025
C2S Validation [Action/Party/Dbox/Equip/Lockstyle/Zoning]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Last PR of first phase with all remaining packets.
Noteworthy:
Steps to test these changes