Skip to content

Create enum for item AH categories#7744

Merged
zach2good merged 1 commit intoLandSandBoat:basefrom
DioCar84:base
Jul 29, 2025
Merged

Create enum for item AH categories#7744
zach2good merged 1 commit intoLandSandBoat:basefrom
DioCar84:base

Conversation

@DioCar84
Copy link
Copy Markdown
Contributor

@DioCar84 DioCar84 commented Jul 24, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Creates an enum xi.itemAHCategory that can be used when comparing the result of calling itemObj:getAHCat(). Replaced integer values with enum entry where getAHCat() is called.

Steps to test these changes

Several calls to itemObj:getAHCat() with different items to ensure the correct Boolean value is returned when comparing the various categories.

@github-actions
Copy link
Copy Markdown

✨ Hello and thanks for the PR! ✨

🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@zach2good
Copy link
Copy Markdown
Contributor

While you're doing this, you should probably also use the enum in the few places where that function is called:
image

@DioCar84
Copy link
Copy Markdown
Contributor Author

DioCar84 commented Jul 24, 2025

Yes excellent suggestion @zach2good. Brain fart moment... I have amended the PR to include using the enum.

@zach2good zach2good merged commit 89b90e2 into LandSandBoat:base Jul 29, 2025
13 checks passed
claybie pushed a commit to claybie/LeafSpringCog that referenced this pull request Aug 11, 2025
Create enum for item AH categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants