Create enum for item AH categories#7744
Merged
zach2good merged 1 commit intoLandSandBoat:basefrom Jul 29, 2025
Merged
Conversation
|
✨ Hello and thanks for the PR! ✨ 🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template. |
Contributor
Contributor
Author
|
Yes excellent suggestion @zach2good. Brain fart moment... I have amended the PR to include using the enum. |
zach2good
approved these changes
Jul 29, 2025
claybie
pushed a commit
to claybie/LeafSpringCog
that referenced
this pull request
Aug 11, 2025
Create enum for item AH categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I affirm:
What does this pull request do?
Creates an enum
xi.itemAHCategorythat can be used when comparing the result of callingitemObj:getAHCat(). Replaced integer values with enum entry wheregetAHCat()is called.Steps to test these changes
Several calls to
itemObj:getAHCat()with different items to ensure the correct Boolean value is returned when comparing the various categories.