Skip to content

[lua, sql] CoP 8-3 When Angels Fall audit#8943

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:when_angels_fall
Jan 4, 2026
Merged

[lua, sql] CoP 8-3 When Angels Fall audit#8943
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:when_angels_fall

Conversation

@CriticalXI
Copy link
Copy Markdown
Contributor

@CriticalXI CriticalXI commented Dec 22, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adjustments to the 8-3 When Angels Fall battlefield:
    • Removed optic induration logic that is already controlled in the mob skill files. This required populating the onMobMobskillChoose in all other Zdei family mobs. Removed form checks from all Zdei skills due to this.
    • I cannot find proof that RDM Ix'zdeis return to their spawn points to heal. Removed that logic, and reworked the existing behavior in BLM Ix'zdeis.
    • Set each RDM and BLM zdei to have either a light or dark spell list with spell observed in captures. Setup to use the new chooseAction util.

Sources

Comment thread scripts/actions/mobskills/optic_induration_charge.lua Outdated
Comment thread scripts/enum/mob_skill.lua
Comment thread scripts/zones/The_Garden_of_RuHmet/mobs/Ixzdei_BLM.lua
@CriticalXI CriticalXI force-pushed the when_angels_fall branch 2 times, most recently from c211c71 to af944bc Compare December 29, 2025 01:09
@Xaver-DaRed Xaver-DaRed merged commit 4dc8960 into LandSandBoat:base Jan 4, 2026
18 of 19 checks passed
@sruon sruon mentioned this pull request Jan 6, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants