Add phys damage additional effect procs, add priority additional effects, scripted additional effects, add excalibur (75-119 III) add effect#8996
Merged
WinterSolstice8 merged 2 commits intoDec 31, 2025
Conversation
Xaver-DaRed
reviewed
Dec 31, 2025
a26b057 to
c6d1922
Compare
Contributor
Author
|
Excalibur proc msg source: https://youtu.be/I9lN2ixnzck 7% rate source (I have seen no data, just numbers) |
Xaver-DaRed
reviewed
Dec 31, 2025
c6d1922 to
653944d
Compare
Xaver-DaRed
approved these changes
Dec 31, 2025
Contributor
Xaver-DaRed
left a comment
There was a problem hiding this comment.
I think we should in the long run default to the script
But on the long run, not now
ac093bb to
1da959a
Compare
1da959a to
35308e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Bunch of stuff but basically
We needed priority add effect support for Excalibur, and the add effect mods couldn't cut it too well for this edge case so I added scripting support
Fixed add effects not dealing damage or healing (kill me)
Closes #4378
Steps to test these changes
die in front of the keyboard after testing stuff and realizing damage/healing wasn't being dealt (but now is)