Skip to content

Add phys damage additional effect procs, add priority additional effects, scripted additional effects, add excalibur (75-119 III) add effect#8996

Merged
WinterSolstice8 merged 2 commits into
LandSandBoat:basefrom
WinterSolstice8:item_Addeffect_stuff_excal
Dec 31, 2025
Merged

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

@WinterSolstice8 WinterSolstice8 commented Dec 31, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Bunch of stuff but basically
We needed priority add effect support for Excalibur, and the add effect mods couldn't cut it too well for this edge case so I added scripting support

Fixed add effects not dealing damage or healing (kill me)

Closes #4378

Steps to test these changes

die in front of the keyboard after testing stuff and realizing damage/healing wasn't being dealt (but now is)

Comment thread scripts/items/excalibur_119.lua Outdated
@WinterSolstice8 WinterSolstice8 force-pushed the item_Addeffect_stuff_excal branch 2 times, most recently from a26b057 to c6d1922 Compare December 31, 2025 02:38
@WinterSolstice8
Copy link
Copy Markdown
Contributor Author

Comment thread scripts/items/excalibur_75.lua Outdated
@WinterSolstice8 WinterSolstice8 force-pushed the item_Addeffect_stuff_excal branch from c6d1922 to 653944d Compare December 31, 2025 02:41
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should in the long run default to the script

But on the long run, not now

@WinterSolstice8 WinterSolstice8 force-pushed the item_Addeffect_stuff_excal branch 2 times, most recently from ac093bb to 1da959a Compare December 31, 2025 02:47
@WinterSolstice8 WinterSolstice8 force-pushed the item_Addeffect_stuff_excal branch from 1da959a to 35308e2 Compare December 31, 2025 04:29
@WinterSolstice8 WinterSolstice8 merged commit e25400c into LandSandBoat:base Dec 31, 2025
34 of 37 checks passed
@WinterSolstice8 WinterSolstice8 deleted the item_Addeffect_stuff_excal branch December 31, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Excalibur additional effect not proccing

2 participants