Skip to content

Conversation

@sruon
Copy link
Contributor

@sruon sruon commented Jan 6, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Injected a whole bunch of packets on retail and covered the cases to the best of my ability. Very likely still has a few gaps.

The one thing I'm not entirely sure on is talking to NPC/disengage while prevented from acting. Retail absolutely honors both while asleep but I am not quite sure if that extends to Stun / Terror etc.

Attacking while fishing has been explicitly disabled even though retail does honor it.

Steps to test these changes

Do stuff? Tested as much as I could but there's a lot of permutations.

@WinterSolstice8 WinterSolstice8 merged commit 90abedc into LandSandBoat:base Jan 6, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants