Skip to content

[Interaction] "Community service" quest minor cleanup#9139

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:quest-cleanup
Jan 23, 2026
Merged

[Interaction] "Community service" quest minor cleanup#9139
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:quest-cleanup

Conversation

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed commented Jan 14, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

As title sais. No real logic changes were made.

  • Changed some npc variables to be zone variables. For consistency more than for anything else.
  • Simplified functions to use less parameters.
  • Created a few global functions to call the quest logic from the zone script. The purpose for this is:
    • Have as much logic as possible centralized inside the quest script.
    • Have ALL variables used by the quest inside the quest script.
  • Changed a quest variable handling to be more clear.

Steps to test these changes

None. This isnt supposed to break nor fix anything.

Comment thread scripts/quests/jeuno/Community_Service.lua Outdated
@Xaver-DaRed Xaver-DaRed force-pushed the quest-cleanup branch 4 times, most recently from ba40da5 to 7f5ec26 Compare January 14, 2026 20:06
@Xaver-DaRed Xaver-DaRed merged commit 902905e into LandSandBoat:base Jan 23, 2026
10 checks passed
@Xaver-DaRed Xaver-DaRed deleted the quest-cleanup branch February 3, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants