Skip to content

[Combat] AEs: Implement effect absorb#9201

Merged
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
Xaver-DaRed:absorb
Jan 21, 2026
Merged

[Combat] AEs: Implement effect absorb#9201
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
Xaver-DaRed:absorb

Conversation

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed commented Jan 21, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Edits dispel code to allow for effect absorption.

Also Close #9203

Steps to test these changes

Do Einherjar. Fight Djigga

@Xaver-DaRed Xaver-DaRed force-pushed the absorb branch 3 times, most recently from 391bda1 to a5ff148 Compare January 21, 2026 04:45
@WinterSolstice8
Copy link
Copy Markdown
Contributor

WinterSolstice8 commented Jan 21, 2026

Immunobreak cant proc unless you resist according to wikis and observation, changing the order is probably not right

https://www.bg-wiki.com/ffxi/Category:Enfeebling_Magic#Immunobreak
image

I tested this and it seems true

image image image

I have Chironic Hose equipped which takes me from res rank 11 to 9 (at the worst case)

image

as I understand it rank 9 is 2.65x meva multiplier, I have around 1150 macc (ignoring dStat), target is lvl 78 earth ele. rank A+ for lvl 78 is 291.

291*2.65 = 771 so I should be capped on mhit rate and yet i'm not landing immunobreak + the debuff on the same cast. Even with Saboteur I can't land on immunobreak.

image

Also, while you're there DRK can proc immunobreak on it's own, the RDM job check is not correct either
image

@Xaver-DaRed
Copy link
Copy Markdown
Contributor Author

I thought I had an old Screenshot of Teo or you triggering both a immunobreak and a success, but since I cant find it, I reverted it.
I cleaned up immunobreak logic while I was there and removed the RDM check as you mentioned.

@WinterSolstice8
Copy link
Copy Markdown
Contributor

It's possible something was changed, I was looking into how all this crap works on a different tangent and I have an unexplained Stymie landing break when I thought I didn't proc immunobreak but 45 minute timer is killing me. These earth elementals seem to be rank 11 on petrify as I need 2 immunobreak procs without hose to land consistently, but I have never landed a single break without an immunobreak

According to the Resist page and break testing i've been doing, rank 11 = never land but not "immune". Immunity is essentially blocking immunobreaks so you can never land the spell

I think we have bigger problems though, on retail, Rayke doesn't effect resistance ranks for statuses (and probably not skillchains either. I havent tested this yet because it's a pain) for the purposes of immunobreak/resist rates on a non-NM which means we're making it easier to land enfeebs than we should be. If the resistance rank is set to 0 on LSB it will pick the elemental resistance rank too which is modified by rayke or skillchains. So maybe we need to remove rayke & scs changing those mods and just calculate it in resistance checks so we can bypass this problem...

The testing I did was to use Rayke with 3x of the rune that theoretically would modify the rank of break out of 11 to 8 to make it trivial to land on an sky earth elemental but I still needed procs of immunobreak to land

@Xaver-DaRed Xaver-DaRed merged commit f4b5e9c into LandSandBoat:base Jan 21, 2026
10 checks passed
@Xaver-DaRed Xaver-DaRed deleted the absorb branch February 3, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 All enfeebling magic is resisted

2 participants