Skip to content

[Fishing] Convert some fishing sql data to lua#9263

Merged
Xaver-DaRed merged 3 commits into
LandSandBoat:basefrom
Xaver-DaRed:FISH
Jan 28, 2026
Merged

[Fishing] Convert some fishing sql data to lua#9263
Xaver-DaRed merged 3 commits into
LandSandBoat:basefrom
Xaver-DaRed:FISH

Conversation

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed commented Jan 27, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fishing will need to be converted to lua at some point or another, for all unimplemented stuff, so I thought we may just start now.

  • Adds fish enums to item.lua
  • Adds/renames fish duplicates and adjusts the enum name when/where used.
  • Converts the 3 main fishing data table to lua, to be used on a future logic rewrite. It was a massive and boring job, but added some TODOs already regarding the data in them.

Steps to test these changes

Nothing to test.

@Xaver-DaRed Xaver-DaRed force-pushed the FISH branch 8 times, most recently from 858bfe9 to 2e7ae8b Compare January 27, 2026 21:15
@Xaver-DaRed Xaver-DaRed force-pushed the FISH branch 2 times, most recently from 2ea9fc6 to 3b54bee Compare January 27, 2026 22:10
@Xaver-DaRed Xaver-DaRed merged commit 006803d into LandSandBoat:base Jan 28, 2026
10 checks passed
@Xaver-DaRed Xaver-DaRed deleted the FISH branch February 3, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants