[core] Unlock items on synthesis failure for recipes that cant lose items#9314
Merged
Conversation
WinterSolstice8
approved these changes
Feb 1, 2026
Xaver-DaRed
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Pretty much just impacts Lu Shang recipes.
handleMaterialLoss is being skipped but its also responsible for unlocking items that aren't lost in every other synths.
Copied a redux of the loop in the else branch
Steps to test these changes
Synth and fail a broken Lu Shang fishing rod. Broken Lu Shang Fishing Rod is unlocked at craft end.