Skip to content

[core] Unlock items on synthesis failure for recipes that cant lose items#9314

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
sruon:synth_fail_unlock
Feb 1, 2026
Merged

[core] Unlock items on synthesis failure for recipes that cant lose items#9314
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
sruon:synth_fail_unlock

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Feb 1, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Pretty much just impacts Lu Shang recipes.

handleMaterialLoss is being skipped but its also responsible for unlocking items that aren't lost in every other synths.
Copied a redux of the loop in the else branch

Steps to test these changes

Synth and fail a broken Lu Shang fishing rod. Broken Lu Shang Fishing Rod is unlocked at craft end.

@Xaver-DaRed Xaver-DaRed merged commit d1ee2c6 into LandSandBoat:base Feb 1, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants