Skip to content

[Magic] Correct day/weather bonus margins and correct Twilight cape behavior#9320

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:fff
Feb 1, 2026
Merged

[Magic] Correct day/weather bonus margins and correct Twilight cape behavior#9320
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Xaver-DaRed:fff

Conversation

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds a new modifier to enhance the day/weather bonus. Unlike the Zodiac ring, it does require a proc.
  • Applies new modifier to fix the Twilight cape behavior.
  • Reduces the clamp upper bound to 1.4

Steps to test these changes

Place prints. Cast.

@Xaver-DaRed Xaver-DaRed enabled auto-merge February 1, 2026 15:16
@Xaver-DaRed Xaver-DaRed merged commit ae9a522 into LandSandBoat:base Feb 1, 2026
10 checks passed
@Xaver-DaRed Xaver-DaRed deleted the fff branch February 3, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants