Skip to content

[fix, lua] Dont trigger resonance on blinked WS#9340

Merged
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
sruon:blinked_ws_skillchain
Feb 3, 2026
Merged

[fix, lua] Dont trigger resonance on blinked WS#9340
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
sruon:blinked_ws_skillchain

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Feb 3, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Weaponskills absorbed by shadows should not open or close a skillchain. It's happening because this specific code path wasn't setting the hit resolution to miss.

Steps to test these changes

@sruon
Copy link
Copy Markdown
Contributor Author

sruon commented Feb 3, 2026

I added another commit to fix similar issues with SMN BPs and BST Ready moves.

Had to change utils.takeShadows to flow the number of shadows back to core for messaging purposes.

@sruon sruon force-pushed the blinked_ws_skillchain branch from 17444c7 to 445a193 Compare February 3, 2026 03:23
@Xaver-DaRed Xaver-DaRed merged commit 7d610fd into LandSandBoat:base Feb 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants