Skip to content

[core] Adjust RNG calls in synthutils to not truncate#9348

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:synth_rng_calls
Feb 3, 2026
Merged

[core] Adjust RNG calls in synthutils to not truncate#9348
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:synth_rng_calls

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closes #9345
Addresses part of #7841

Steps to test these changes

Synth, still get HQs.

Copy link
Copy Markdown
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 1.0f float syntax much more commonly than 1.f, otherwise looks very sane 👍

@WinterSolstice8
Copy link
Copy Markdown
Contributor Author

We use 1.0f float syntax much more commonly than 1.f, otherwise looks very sane 👍

Changed

@Xaver-DaRed Xaver-DaRed merged commit 113ce65 into LandSandBoat:base Feb 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 synth HQ chance randomroll is integer when reference value is float, truncation results.

3 participants