[lua] Simplify doom status, doom counter#9349
Merged
Xaver-DaRed merged 2 commits intoFeb 3, 2026
Merged
Conversation
Lufaise Meadows NM Audits
Contributor
Author
|
I checked my logs - it looks like doom counter is supposed to print 0 then you die so I will adjust this PR |
WinterSolstice8
force-pushed
the
simplify_doom_status
branch
from
9ec14da to
eb2bb6e
Compare
Contributor
Author
New commit works, but it seems like we skip onEffectTick on the first tick most of the time...? It didn't print counter of 9 when it should have (retail starts at 9 for a 30 second doom.) |
Xaver-DaRed
approved these changes
Feb 3, 2026
Frankie-hz
pushed a commit
to Frankie-hz/LSB
that referenced
this pull request
Feb 26, 2026
* Lufaise Meadows NM Audits Lufaise Meadows NM Audits * [lua] Simplify doom status, change doom counter --------- Co-authored-by: Kipling <kiplingffxi@gmail.com>
taylorleary
pushed a commit
to taylorleary/ZenithXI
that referenced
this pull request
Mar 26, 2026
* Lufaise Meadows NM Audits Lufaise Meadows NM Audits * [lua] Simplify doom status, change doom counter --------- Co-authored-by: Kipling <kiplingffxi@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Doom had some weird setPower that doesn't seem to do anything so it was removed.
Additionally, replace the messaging calculation with math.ceil which returns a whole number such as the following:
1.999999 -> 2
2.0 -> 2
2.1 -> 3
See before/after (first set is before, second is after)
Note: with non-divisible by 3 numbers the doom counter may print 0. I don't know if doom is supposed to be resistable to make this a problem, however.
Steps to test these changes
See above