[lua] Adjust mobskills/petskills to pass a table/in out of ALL of them

[WinterSolstice8]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Basically, brute forces some technical debt to die. IF we need to pass parameters between 2 mobskill function calls we can now.
Run this script in git bash (or normal bash on linux) in scripts/actions

then manually edit the rest that LLS indicates to you that failed. Shockingly, the script catches all but a handful of edgecases.

Manually review changes in mobskills.lua, there aren't many, I added LLS definitions and some other minor changes

#/bin/bash

#execute in scripts/actions/

files=$(find . -name "*.lua")

for file in $files; do
    # mobPhysicalMove conversion:
    sed -i 's/info.damage/info/g' "$file"
    sed -i 's/info.dmg/info/g' "$file"

    # mobMagical/BreathMove conversion
    sed -i '/mobMagicalMove/s/local damage =/local info =/g' "$file"
    sed -i '/\s\s\s\sdamage =.*mobBreath/s/damage =/local info =/g' "$file"
    sed -i '/\s\s\s\sdamage =.*mobMagical/s/damage =/local info =/g' "$file"
    sed -i '/\s\s\s\slocal damage =.*mobMagical/s/local damage =/local info =/g' "$file"
    sed -i '/\s\s\s\slocal damage =.*mobBreath/s/local damage =/local info =/g' "$file"
    sed -i '/\s\s\s\sdmg =.*mobMagical/s/dmg =/local info =/g' "$file"
    sed -i '/\s\s\s\sdmg =.*mobBreath/s/dmg =/local info =/g' "$file"
    sed -i '/\s\s\s\slocal dmg =.*mobMagical/s/local dmg =/local info =/g' "$file"
    sed -i '/\s\s\s\slocal dmg =.*mobBreath/s/local dmg =/local info =/g' "$file"
    sed -i 's/mobFinalAdjustments(damage,/mobFinalAdjustments(info,/g' "$file"
    sed -i 's/avatarFinalAdjustments(damage,/avatarFinalAdjustments(info,/g' "$file"
    sed -i 's/damage = xi.mobskills.mobAddBonuses(pet, target, damage/info.damage = xi.mobskills.mobAddBonuses(pet, target, info.damage/g' $file

done

# final edits for edge cases
for file in $files; do
    if [ -f "$file" ]; then
        # file doesn't contain "local damage =" or "local dmg ="
        if ! grep -iqE "local (damage|dmg) =" "$file" ; then
            if grep -iqE "(mobmagical|mobbreath)" "$file" ; then # file does contain mobmagical or mobbreath
                sed -i "s/damage = xi.mobskills.mobFinalAdjustments/local damage = xi.mobskills.mobFinalAdjustments/g" $file
                sed -i "s/dmg = xi.mobskills.mobFinalAdjustments/local dmg = xi.mobskills.mobFinalAdjustments/g" $file
            fi
        fi
    fi
done

Steps to test these changes

use mobskills and petskills

Etc

[WinterSolstice8]

This is probably as good as it's gonna get... so undrafted

[Xaver-DaRed]

YOLO...