[lua] Breath Mobskill Adjustments#9383
Merged
Xaver-DaRed merged 1 commit intoFeb 8, 2026
Merged
Conversation
51840b5 to
c4aa215
Compare
c4aa215 to
53cd826
Compare
| if mob:isPet() and mob:getMaster() ~= nil then | ||
| mAccuracyBonus = mAccuracyBonus + 25 -- TODO: This is based off a previous function. Would eventually like to get a capture for this. | ||
|
|
||
| -- TODO: Do jug pet breaths gain damage or only an accuracy bonus? |
Contributor
There was a problem hiding this comment.
It is worth noting that SE has explicitly stated (and this is apparent in testing) that Dragoon Wyvern breath MBs only boost macc
Contributor
Author
There was a problem hiding this comment.
I did consider this but then I saw player DRG breaths were being self contained in the DRG job utils. Would we eventually want to migrate them over to use this?
Contributor
There was a problem hiding this comment.
Hmm... maybe. Worth thinking about, i'm not sure how well the absorb/nullify etc checks are and in what order. It's a minor problem compared to mob breath skills
WinterSolstice8
approved these changes
Feb 7, 2026
Xaver-DaRed
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Backports some features/mobskill handling from my future updated Magical mobskill PR.
Adds action to onMobWeaponSkill() in mobskill scripts. This is already exposed but was missing from the scripts.
Corrects order of Nullification and Absorb. Nullification takes precedence over absorb.
Eliminates usage of mobFinalAdjustments() for mobBreathMove(). The functions within have been integrated in to the mobBreathMove() function.
Uses function processDamage() to prevent chip damage through shadows. (Replaces hasMissMessage())
Note: Captures show status effects will still apply even if an attack if absorbed or nullified. (We still count hitsLanded when absorb or nullify occurs)
Fixes double spacing in breath skill script params.
Converts mobskill "Aeolian Void" to a magic skill using values from Jimmayus's spreadsheet.
Steps to test these changes
I tested the skills by hand.
If you want to test yourself:
!setmod FIRE_ABSORB 100 <me>!exec target:useMobAbility(800, player)-- Skill ID 800 = Heat Breath
See that you will absorb the damage.
!setmod FIRE_NULL 100 <me>!exec target:useMobAbility(800, player)-- See that you now nullify the damage over absorbing it.
Breath skills usually ignore shadows but the capability to have differing shadow behavior is preserved.
-- Open the heat_breath.lua script. Adjust shadowBehavior to NUMSHADOWS_1 from IGNORE_SHADOWS.
-- Cast Utsusemi on yourself and see that it will now only take 1 shadow.
-- Note, the messaging will still display 0 shadows taken, a known issue until the rest of mobskills are ported so we don't take chip damage.