Skip to content

[lua] Breath Mobskill Adjustments#9383

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:Breath_Mobskill_Adjustments
Feb 8, 2026
Merged

[lua] Breath Mobskill Adjustments#9383
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:Breath_Mobskill_Adjustments

Conversation

@UmeboshiXI
Copy link
Copy Markdown
Contributor

@UmeboshiXI UmeboshiXI commented Feb 6, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Backports some features/mobskill handling from my future updated Magical mobskill PR.

  • Adds action to onMobWeaponSkill() in mobskill scripts. This is already exposed but was missing from the scripts.

  • Corrects order of Nullification and Absorb. Nullification takes precedence over absorb.

  • Eliminates usage of mobFinalAdjustments() for mobBreathMove(). The functions within have been integrated in to the mobBreathMove() function.

  • Uses function processDamage() to prevent chip damage through shadows. (Replaces hasMissMessage())

  • Note: Captures show status effects will still apply even if an attack if absorbed or nullified. (We still count hitsLanded when absorb or nullify occurs)

  • Fixes double spacing in breath skill script params.

  • Converts mobskill "Aeolian Void" to a magic skill using values from Jimmayus's spreadsheet.

Steps to test these changes

I tested the skills by hand.

If you want to test yourself:

  1. !setmod FIRE_ABSORB 100 <me>

  2. !exec target:useMobAbility(800, player)
    -- Skill ID 800 = Heat Breath
    See that you will absorb the damage.

  3. !setmod FIRE_NULL 100 <me>

  4. !exec target:useMobAbility(800, player)
    -- See that you now nullify the damage over absorbing it.

  5. Breath skills usually ignore shadows but the capability to have differing shadow behavior is preserved.
    -- Open the heat_breath.lua script. Adjust shadowBehavior to NUMSHADOWS_1 from IGNORE_SHADOWS.
    -- Cast Utsusemi on yourself and see that it will now only take 1 shadow.
    -- Note, the messaging will still display 0 shadows taken, a known issue until the rest of mobskills are ported so we don't take chip damage.

@UmeboshiXI UmeboshiXI force-pushed the Breath_Mobskill_Adjustments branch 4 times, most recently from 51840b5 to c4aa215 Compare February 6, 2026 09:54
@UmeboshiXI UmeboshiXI force-pushed the Breath_Mobskill_Adjustments branch from c4aa215 to 53cd826 Compare February 6, 2026 10:50
@UmeboshiXI UmeboshiXI marked this pull request as ready for review February 6, 2026 11:15
if mob:isPet() and mob:getMaster() ~= nil then
mAccuracyBonus = mAccuracyBonus + 25 -- TODO: This is based off a previous function. Would eventually like to get a capture for this.

-- TODO: Do jug pet breaths gain damage or only an accuracy bonus?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is worth noting that SE has explicitly stated (and this is apparent in testing) that Dragoon Wyvern breath MBs only boost macc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider this but then I saw player DRG breaths were being self contained in the DRG job utils. Would we eventually want to migrate them over to use this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... maybe. Worth thinking about, i'm not sure how well the absorb/nullify etc checks are and in what order. It's a minor problem compared to mob breath skills

@Xaver-DaRed Xaver-DaRed merged commit 02f0c6f into LandSandBoat:base Feb 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants