[core] Track inventory containers client load state [inventory sort fix]#9409
Merged
Conversation
WinterSolstice8
approved these changes
Feb 9, 2026
|
This PR has been automatically marked as stale because |
taylorleary
pushed a commit
to taylorleary/ZenithXI
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Fixes inventory unsorting, closes #7647
ITEM_SAME was generally being sent as either "nothing is loaded" or "everything is loaded" when zoning in which led the client to believe it could now load the cache files (storing the SortKeys client side).
When the client attempted to match items in the cache file, they were not found and so it silently reverted to the server order.
Equipping items during zoning emitted several ITEM_SAME leading to the condition.
This PR:
Credits to B.O. for the scenario and @WinterSolstice8 for pointing out the equipment packets were not entirely accurate.
Steps to test these changes
Zone with equipped items and a manually sorted inventory -> sort is still there after zoning.
Draft because I only really tested the reproducible scenario. Hoping some nice operator can pull it in and give feedback...