Skip to content

[core,lua] Refactor addStatusEffect 💣#9506

Merged
Xaver-DaRed merged 3 commits into
LandSandBoat:basefrom
sruon:addStatusEffect
Feb 21, 2026
Merged

[core,lua] Refactor addStatusEffect 💣#9506
Xaver-DaRed merged 3 commits into
LandSandBoat:basefrom
sruon:addStatusEffect

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Feb 21, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Gets rid of addStatusEffectEx and merge everything into one binding with a named table based API.
    • Almost every parameter is optional except the origin of the status effect.
    • Yes, this will break all of your custom code
  • Introduces a dedicated copyStatusEffect that clones a given effect with remaining duration.
  • Lua scripts were updated with a combinations of regexp and sed and it was incredibly annoying.
    • Microspores had some changes done because I don't believe it was working correctly but I'm retesting...
    • Contagion / Wyverns were updated to make use of copyStatusEffect

Steps to test these changes

@LandSandBoat LandSandBoat deleted a comment from github-actions Bot Feb 21, 2026
@sruon sruon marked this pull request as ready for review February 21, 2026 05:45
@sruon
Copy link
Copy Markdown
Contributor Author

sruon commented Feb 21, 2026

Retested a little bit of everything:

  • /heal & /logout
  • DRG Empathy
  • Massive !provokeall in Dynamis-Bastok to test various mobskills
  • Trusts buffing
  • Scroll of Instant XX
  • Hydra Haubert
  • SMN Blood Pacts buffs / Avatar's Favor
  • Weaponskills debuffs
  • Absorbing Shield
  • Moa Constrictors for Contamination
  • Entered BCNM with a summoned pet

This unblocks #9473

@Xaver-DaRed Xaver-DaRed merged commit 127cda7 into LandSandBoat:base Feb 21, 2026
10 checks passed
@sruon sruon deleted the addStatusEffect branch February 21, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants