Skip to content

[core, sql] Status effect wear off messages, ON_ZONE flags#9517

Merged
WinterSolstice8 merged 2 commits into
LandSandBoat:basefrom
sruon:status_effect_msgids
Feb 24, 2026
Merged

[core, sql] Status effect wear off messages, ON_ZONE flags#9517
WinterSolstice8 merged 2 commits into
LandSandBoat:basefrom
sruon:status_effect_msgids

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Feb 23, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds a new column to override the wear off message for status effects
    • After going through the motions I'm not even sure it was required to begin with because everything is either message 204 or 206 but might be useful later on...
  • Adds the correct message ID for certain status effects wearing off
    • Tested what I could myself, used Youtube videos for a few and made some assumptions about a limited number. Likely not ENTIRELY accurate.
  • Defines the flags explicitly in the SQL file
  • Adds ON_ZONE flag to a lot of status effects
  • Sets the correct "caster" entity in the wear off message, as observed on retail
    • Makes no visual difference but I don't think filters can work correctly otherwise.

Maybe closes #8898 - need another pass

Steps to test these changes

Co-Authored-By: siknoz <78240569+siknoz@users.noreply.github.com>
@sruon sruon force-pushed the status_effect_msgids branch from c3b8861 to e7d8e23 Compare February 23, 2026 02:09
Comment thread sql/status_effects.sql
INSERT INTO `status_effects` VALUES (152,'magic_shield',@FLAG_DISPELABLE | @FLAG_EMPATHY | @FLAG_DEATH,0,0,0,0,0,0,0,0,NULL);
INSERT INTO `status_effects` VALUES (153,'damage_spikes',@FLAG_DISPELABLE | @FLAG_EMPATHY | @FLAG_DEATH,34,0,0,0,0,0,0,800,NULL);
INSERT INTO `status_effects` VALUES (154,'shining_ruby',@FLAG_DISPELABLE | @FLAG_EMPATHY | @FLAG_DEATH | @FLAG_ON_ZONE,0,0,0,0,0,0,0,0,NULL);
INSERT INTO `status_effects` VALUES (155,'medicine',0,0,0,0,0,0,0,0,0,204);
Copy link
Copy Markdown

@almuth150 almuth150 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this status has no flags. I checked with a test server and couldn't manually remove the status with the client normally, so maybe this status should have the no cancel flag? I can't check on retail though. But surely the status that prevents you from using certain powerful meds repeatedly shouldn't be able to be removed by the player.

Edit: It looks like there are more statuses that lack that flag, so I'm going to open a separate issue. Ignore this for this PR.

@WinterSolstice8 WinterSolstice8 merged commit caa3e88 into LandSandBoat:base Feb 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certain Effects should be lost when Zoning

3 participants