[lua, c++] WoTG 37 + 46 - Spitewarden Mimicry#9530
Merged
Conversation
b3dfabb to
0c7e4b2
Compare
Xaver-DaRed
reviewed
Feb 25, 2026
| * Purpose : Copies a player's equipped appearance onto a mob | ||
| * Example : mob:setLookFromPlayer(player) | ||
| * Note : Preserves the mob's own legs/feet and copies model size | ||
| ************************************************************************/ |
Contributor
There was a problem hiding this comment.
What is the use-case of this function right now?
I'd rather itd be introduced when needed instead of "in advance"
Contributor
Author
There was a problem hiding this comment.
For future battlefield implementation of WoTG 46
https://ffxiclopedia.fandom.com/wiki/When_Wills_Collide
Contributor
There was a problem hiding this comment.
It can be introduced with that quest, if needed.
No issues with the function in itself, but, introducing functions that arent used has brought us problems in the past.
Contributor
There was a problem hiding this comment.
fyi this binding could be expanded instead of making a new one.
/************************************************************************
* Function: setLook()
* Purpose : Updates the look of an equipped NPC
* Example : npc:setLook({ race = xi.race.HUME_M, face = 1 })
* Note : Only for equipped NPCs that dynamically change their race/face
************************************************************************/
void CLuaBaseEntity::setLook(const sol::table& look)
{
if (auto* PNpc = dynamic_cast<CNpcEntity*>(m_PBaseEntity))
{
PNpc->look.size = MODEL_EQUIPPED;
PNpc->look.face = look.get_or<uint32>("face", 0);
PNpc->look.race = look.get_or<uint32>("race", 0);
return;
}
ShowWarning("Invalid entity type calling function (%s).", m_PBaseEntity->getName());
}
0c7e4b2 to
46a597d
Compare
Xaver-DaRed
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Corrects model for the Fourth Spitewarden to mimicry the player's face and currently equipped gear (excluding legs/feet as those are unique to the model) in the cutscenes for missions 37 and 46. I Included a setLookfromPlayer function as well that can later be used for the battlefield mimicry function when entering WoTG 46 BCNM, but I could always remove it on request.
Steps to test these changes
!zone 156!addmission 5 36!cs 10!zone 182!addmission 5 45!cs 1