Skip to content

[core] nullptr check for Rune Enhancement#9664

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Omnione:trust_work
Mar 24, 2026
Merged

[core] nullptr check for Rune Enhancement#9664
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Omnione:trust_work

Conversation

@Omnione
Copy link
Copy Markdown
Contributor

@Omnione Omnione commented Mar 23, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds a nullptr check for weapons in battleutils.cpp for Rune Enhancment, to prevent crashes when entities other than player characters have en dmg calculated.

Steps to test these changes

Call Amachuchu to fight, engage a mob, she should use runes and do en dmg but not crash the server.

@Xaver-DaRed Xaver-DaRed merged commit 907822a into LandSandBoat:base Mar 24, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants