[lua] Refactor PDIF clamping and simplify code#9675
Merged
Conversation
5dc5c37 to
aa97d94
Compare
Xaver-DaRed
reviewed
Mar 27, 2026
Xaver-DaRed
reviewed
Mar 27, 2026
aa97d94 to
688dda7
Compare
688dda7 to
cc3e1f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
After talking to Jimmayus and other math nerds in the math nerds group chat..
adjusts ranged pdif to be half of melee pdif
Corrects pdif caps for corrected areas/non corrected areas for mobs via a note in https://forum.square-enix.com/ffxi/threads/31310-March-27-2013-(JST)-Version-Update
mobs in a corrected zone should be able to reach 3.0 pdif after crit and then another 1.0 pdif from correction
cratio cap: 2
pre randomizer cap: 4
but when in a non-corrected zone, the caps are the same.
Refactors usage of caps (there was some clamps that were not necessary based off of player optimizations on the wiki and not reality)
Closes phoenixffxi#38
Steps to test these changes
get meleed by stuff