Skip to content

[lua] Refactor PDIF clamping and simplify code#9675

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:pdif_adjustments
Mar 31, 2026
Merged

[lua] Refactor PDIF clamping and simplify code#9675
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:pdif_adjustments

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

@WinterSolstice8 WinterSolstice8 commented Mar 27, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

After talking to Jimmayus and other math nerds in the math nerds group chat..

adjusts ranged pdif to be half of melee pdif

Corrects pdif caps for corrected areas/non corrected areas for mobs via a note in https://forum.square-enix.com/ffxi/threads/31310-March-27-2013-(JST)-Version-Update

mobs in a corrected zone should be able to reach 3.0 pdif after crit and then another 1.0 pdif from correction

cratio cap: 2
pre randomizer cap: 4

but when in a non-corrected zone, the caps are the same.
Refactors usage of caps (there was some clamps that were not necessary based off of player optimizations on the wiki and not reality)

Closes phoenixffxi#38

Steps to test these changes

get meleed by stuff

@WinterSolstice8 WinterSolstice8 marked this pull request as draft March 27, 2026 01:46
@WinterSolstice8 WinterSolstice8 force-pushed the pdif_adjustments branch 2 times, most recently from 5dc5c37 to aa97d94 Compare March 27, 2026 03:01
@WinterSolstice8 WinterSolstice8 changed the title [lua] Adjust some PDIF caps, use half the melee correction for ranged [lua] Refactor PDIF Mar 27, 2026
@WinterSolstice8 WinterSolstice8 changed the title [lua] Refactor PDIF [lua] Refactor PDIF clamping and simplify code Mar 27, 2026
Comment thread scripts/globals/combat/physical_utilities.lua Outdated
Comment thread scripts/globals/combat/physical_utilities.lua
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@WinterSolstice8 WinterSolstice8 marked this pull request as ready for review March 31, 2026 00:02
@Xaver-DaRed Xaver-DaRed merged commit 694db8d into LandSandBoat:base Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Level Correction (Cratio) is incorrect

2 participants