[lua] Fix edge cases that report incorrect misses for mob/weaponskill#9694
Merged
WinterSolstice8 merged 1 commit intoMar 31, 2026
Merged
Conversation
WinterSolstice8
commented
Mar 31, 2026
|
|
||
| -- Do the extra hit for our offhand if applicable | ||
| if calcParams.extraOffhandHit and hitsDone < 8 and finaldmg < targetHp then | ||
| calcParams.hitsLanded = 0 |
Contributor
Author
There was a problem hiding this comment.
This was being reset for no reason. It's only incremented inside getSingleHitDamage and was previously checked nowhere else.
WinterSolstice8
commented
Mar 31, 2026
|
|
||
| while hitsDone < 8 and offhandMultiHitsDone < numOffhandMultis and finaldmg < targetHp do | ||
| local offhandDmg = calcParams.weaponDamage[2] + calcParams.fSTR + wsc * alpha | ||
| calcParams.hitsLanded = 0 |
Contributor
Author
There was a problem hiding this comment.
This was being reset for no reason. It's only incremented inside getSingleHitDamage and was previously checked nowhere else.
Xaver-DaRed
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Weaponskills and mobskills could report a "miss" even if the WS didn't actually miss, you just dealt zero damage
Steps to test these changes
Give a mob or yourself invincible, test mobskill/weaponskill reporting 0 damage
also check miss still works
