Skip to content

[core] Filter additional bad equip packets#9698

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
WinterSolstice8:equip_stuff
Apr 3, 2026
Merged

[core] Filter additional bad equip packets#9698
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
WinterSolstice8:equip_stuff

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

@WinterSolstice8 WinterSolstice8 commented Apr 2, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

There were some unhandled cases in the equip packet where we would do pending equip screen updates for invalid equips so I filtered them out. I also discovered a missing packet emission if your client allows you to equip dual wield items but you dont have dual wield. This can happen naturally on retail if you are BLU main, THF main, DNC or /DNC, NIN or /NIN but didnt set the Dual Wield trait or are too low to dual wield. It also happens if you inject on a job combo that can't dual wield at all.

This has a side effect of not resetting TP when you were trying to do an invalid equip since the code path exits early. This seems accurate to retail on testing.

Steps to test these changes

when dual wielding, try to equip a dagger in main and offhand (a single item) and see the offhand not appear as a "phantom equip"
try to equip single ring/earring in two slots and see no "phantom" equips

try to equip a dagger in offhand via injection to sub slot when 2 handing and not see a "phantom" equip
/lac equip sub "Ceremonial dagger" will do the trick
try to equip a dagger when you don't have dual wield in the sub slot and get a message telling you that you can't do that
image
image

Also emit the "you cant dual wield that" message when appropriate
@Xaver-DaRed Xaver-DaRed merged commit 25e0fad into LandSandBoat:base Apr 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants