[core] Filter additional bad equip packets#9698
Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom Apr 3, 2026
Merged
[core] Filter additional bad equip packets#9698Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Conversation
Also emit the "you cant dual wield that" message when appropriate
Xaver-DaRed
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
There were some unhandled cases in the equip packet where we would do pending equip screen updates for invalid equips so I filtered them out. I also discovered a missing packet emission if your client allows you to equip dual wield items but you dont have dual wield. This can happen naturally on retail if you are BLU main, THF main, DNC or /DNC, NIN or /NIN but didnt set the Dual Wield trait or are too low to dual wield. It also happens if you inject on a job combo that can't dual wield at all.
This has a side effect of not resetting TP when you were trying to do an invalid equip since the code path exits early. This seems accurate to retail on testing.
Steps to test these changes
when dual wielding, try to equip a dagger in main and offhand (a single item) and see the offhand not appear as a "phantom equip"
try to equip single ring/earring in two slots and see no "phantom" equips
try to equip a dagger in offhand via injection to sub slot when 2 handing and not see a "phantom" equip


/lac equip sub "Ceremonial dagger"will do the tricktry to equip a dagger when you don't have dual wield in the sub slot and get a message telling you that you can't do that