Skip to content

[lua] Replace magic numbers in TOAU shops#9699

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Hatberg:magic-numbers-ahturgan-alzahbi
Apr 3, 2026
Merged

[lua] Replace magic numbers in TOAU shops#9699
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Hatberg:magic-numbers-ahturgan-alzahbi

Conversation

@Hatberg
Copy link
Copy Markdown
Contributor

@Hatberg Hatberg commented Apr 2, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Replaces Magic Numbers from TOAU NPC shop luas with xi.item.ITEMIDS.
  • Replaces Magic Numbers from Selbina NPCs

Steps to test these changes

SELBINA:
!zone Selbina
!gotoname Melyon
!additem 629 3
Trade 3x Millioncorn to Melyon
!additem 4366 5
Trade 5x La Theine Cabbage to Melyon

!gotoname Romeo
!additem 16482 5
Trade 5x Onion Dagger to Romeo
(Quest is not repeatable)

AHT URGAN:
!zone Aht Urgan
!gotoname Bajahb
Compare shop contents

!gotoname Dwago
Compare shop contents

!gotoname Fayeewah
Compare shop contents

!gotoname Gavrie
Compare shop contents

!gotoname Hagakoff
Compare shop contents

!gotoname Khaf_Jhifanm
Compare shop contents

!gotoname Kulh_Amariyo
Compare shop contents

!gotoname Malfud
Compare shop contents

!gotoname Mazween
Compare shop contents

!gotoname Mulnith
Compare shop contents

!gotoname Rubahah
Compare shop contents

!gotoname Saluhwa
Compare shop contents

!gotoname Yafaaf
Compare shop contents

AL ZAHBI
!zone Al Zahbi
!gotoname Allard
Compare shop contents

!gotoname Chayaya
Compare shop contents

!gotoname Kahah_Hobichai
Compare shop contents

!gotoname Zafif
Compare shop contents

@Xaver-DaRed Xaver-DaRed merged commit c2fe742 into LandSandBoat:base Apr 3, 2026
11 checks passed
@Hatberg Hatberg deleted the magic-numbers-ahturgan-alzahbi branch April 3, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants