Skip to content

[core] Always fetch subjob when saving char to db#9703

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
WinterSolstice8:sj_restriction_bug
Apr 4, 2026
Merged

[core] Always fetch subjob when saving char to db#9703
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
WinterSolstice8:sj_restriction_bug

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

When logging out, the DB was fetching "NONE" as your sub if you had the SJ restriction status effect so when you logged in you'd never get your sub back if you removed SJ restriction.

Steps to test these changes

add SJ restriction, logout, log back int, remove SJ restriction and get your sub back

@WinterSolstice8 WinterSolstice8 added hold On hold, pending further action/info and removed hold On hold, pending further action/info labels Apr 3, 2026
@Xaver-DaRed Xaver-DaRed merged commit 2f43f5e into LandSandBoat:base Apr 4, 2026
11 of 13 checks passed
@WinterSolstice8 WinterSolstice8 deleted the sj_restriction_bug branch April 4, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants