Skip to content

[core, lua] Exdata definitions part 4 [Escutcheons/Unlockable weapons/Soul Plate/Soul Reflector/Fish]#9712

Merged
WinterSolstice8 merged 1 commit intoLandSandBoat:basefrom
sruon:exdata_4
Apr 4, 2026
Merged

[core, lua] Exdata definitions part 4 [Escutcheons/Unlockable weapons/Soul Plate/Soul Reflector/Fish]#9712
WinterSolstice8 merged 1 commit intoLandSandBoat:basefrom
sruon:exdata_4

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 4, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Exdata definitions for:

  • Escutcheons
  • Weapon unlock
  • Soul plate
  • Soul reflectors
  • Fish

Misc:

  • Removes some dead code from CItemFish
  • Let weapon unlock points saving fall through to the dirty system so we're not duplicating the same SQL query in several places
  • Fix a typo in ASA mission Soul Plate turn-in
  • Unlock traded soul plates with Ryo and Sanraku so they're not reserved/locked
  • Deprecates a handful of lua bindings related to soul plates since everything is handled by exdata
    • There was another small issue with the packing of FP skills in the existing binding
  • Rework Soulplate name packing/unpacking to more closely adhere to what the client does, which resolves some corruption on the last character
  • Unrelated bugfix for IEP mobs checking as TW

Steps to test these changes

  • Added a fish (Lik) with custom command, verified it showed
  • Took many pictures, verified names and everything was correct with custom addon
  • Added a reflector with custom command, and verified with custom addon
  • Used Destroyers on a mob, verified the unlock points were increasing

@sruon sruon force-pushed the exdata_4 branch 2 times, most recently from c84a2fa to 9d8ab38 Compare April 4, 2026 06:13
Escutcheons
Weapon unlock
Soul plate
Soul reflectors
Fish

Co-Authored-By: atom0s <atom0s@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased for CI LLS

@WinterSolstice8 WinterSolstice8 merged commit 1fef1bb into LandSandBoat:base Apr 4, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants