Skip to content

[core] Limit delivery box to 128 items in flight#9737

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:dbox_128_limit
Apr 8, 2026
Merged

[core] Limit delivery box to 128 items in flight#9737
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:dbox_128_limit

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 8, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Limits dbox to 128+8 slots mirroring retail.
Adds appropriate error packet when recipient dbox is full when attempting to send OR return
Adds an extra packet to dbox flows as I noticed retail did. Doesn't appear to change much though.

Notes:

  • Return error packet WILL NOT PRINT AN ERROR MESSAGE - this is the client behaving as coded and is not a bug
  • Unlike retail, this does not destroy AH gil and returned items because that change is a little more involved and I don't feel there's any good reason for it.
image

Steps to test these changes

Reduce the limit to 3 and send yourself 4 items...

@sruon
Copy link
Copy Markdown
Contributor Author

sruon commented Apr 8, 2026

Forgot to mention but Martel did the original testing. I don't know if they have a GitHub handle.

@Xaver-DaRed Xaver-DaRed merged commit 0620859 into LandSandBoat:base Apr 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants