[core] Limit delivery box to 128 items in flight#9737
Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom Apr 8, 2026
Merged
[core] Limit delivery box to 128 items in flight#9737Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Conversation
WinterSolstice8
approved these changes
Apr 8, 2026
Contributor
Author
|
Forgot to mention but Martel did the original testing. I don't know if they have a GitHub handle. |
zach2good
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Limits dbox to 128+8 slots mirroring retail.
Adds appropriate error packet when recipient dbox is full when attempting to send OR return
Adds an extra packet to dbox flows as I noticed retail did. Doesn't appear to change much though.
Notes:
Steps to test these changes
Reduce the limit to 3 and send yourself 4 items...