Skip to content

[core, sql] Expand item flags#9745

Merged
Xaver-DaRed merged 3 commits intoLandSandBoat:basefrom
sruon:item_flags_rework
Apr 9, 2026
Merged

[core, sql] Expand item flags#9745
Xaver-DaRed merged 3 commits intoLandSandBoat:basefrom
sruon:item_flags_rework

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 9, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

3 commits to prep a larger item audit:

  • First one widens item flags to uint32 to accommodate several new flags for behaviors we need to codify on certain items.
  • Second one cleans up the existing item flags, moves them to an enum class and introduce 2 new flags
    • WALLHANGING becomes AugSendable
    • 01 becomes GMOnly
    • NoRareCheck is introduced for future logic to allow owned rare/ex items to still be placed in the treasure pool
    • NoRecycle is introduced to replace the item IDs match we do for items that do need to skip the recycle bin as the list keeps growing
  • Third one expands all the flags in item_basics SQL file
    • Largely impossible to review but I did spend a decent amount of time ensuring the values matched

Removed a bit of logic dealing with Furniture wallhanging because that flag just doesn't exist at this level. I'm tracking furniture data separately to eventually reintroduce it later.

Steps to test these changes

Should not change anything at this point, the code largely behaves the same way.

@sruon sruon force-pushed the item_flags_rework branch from 089db9c to 7ffd5e4 Compare April 9, 2026 14:08
@Xaver-DaRed Xaver-DaRed merged commit 534adb0 into LandSandBoat:base Apr 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants