[login] Adjust char info management during the lifetime of data_session#9746
Merged
WinterSolstice8 merged 1 commit intoLandSandBoat:basefrom Apr 9, 2026
Merged
Conversation
WinterSolstice8
force-pushed
the
char_info_management
branch
3 times, most recently
from
ad94439 to
589d721
Compare
zach2good
approved these changes
Apr 9, 2026
This fixes a bug with multi-deletion or deletion->char creation Co-Authored-By: atom0s <atom0s@users.noreply.github.com>
WinterSolstice8
force-pushed
the
char_info_management
branch
from
589d721 to
ce528ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This fixes a bug with multi-deletion or deletion->char creation
Fixes #9739
Basically, the client keeps track of the first char info you send and expects slots to be emptied and filled in. For some reason it does not always refresh the list with the new data.
Steps to test these changes
Delete multiple characters, get the correct char ID deletion for the 2nd+
Delete a character that's not the last of the IDs, create a new one and log in as that character instead of a different one