Skip to content

[sql] Items audit [usable / equipment / weapons]#9761

Merged
Xaver-DaRed merged 4 commits intoLandSandBoat:basefrom
sruon:audit_items_2
Apr 11, 2026
Merged

[sql] Items audit [usable / equipment / weapons]#9761
Xaver-DaRed merged 4 commits intoLandSandBoat:basefrom
sruon:audit_items_2

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 11, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Review by commit

7e75c5e

  • Updates usable items with proper activation time and target flags
  • Adds a handful of charged weapons/equipment that were missing entries

Done with a script. Checked a handful of implemented items like Signet staves, Soultrapper.

Target flags changes in an easier to review format

ID Name Before After
4206 bottle_of_catholicon 29 (Self+Enemy+Alliance+Player) 75 (Self+Party+Alliance+NPC)
4208 bottle_of_catholicon_+1 29 (Self+Enemy+Alliance+Player) 75 (Self+Party+Alliance+NPC)
5895 odorless_fungus 1 (Self) 4 (Enemy)
5896 clump_of_absorbent_moss 1 (Self) 4 (Enemy)
5897 redolent_root 1 (Self) 4 (Enemy)
5898 shadescale_skull 1 (Self) 4 (Enemy)
5899 shadescale_femur 1 (Self) 4 (Enemy)
5900 shadescale_talon 1 (Self) 4 (Enemy)
5901 shadescale_heart 1 (Self) 4 (Enemy)
5902 vial_of_cagebeast_blood 1 (Self) 4 (Enemy)
5903 vial_of_sea_monk_venom 1 (Self) 4 (Enemy)
5904 perforated_wing 1 (Self) 4 (Enemy)
5905 undying_moiety 1 (Self) 4 (Enemy)
6002 trailblazing_pickaxe 1 (Self) 68 (Enemy+NPC)
6003 trailblazing_pickaxe_+1 1 (Self) 68 (Enemy+NPC)
6004 trailblazing_hatchet 1 (Self) 68 (Enemy+NPC)
6005 trailblazing_hatchet_+1 1 (Self) 68 (Enemy+NPC)
6006 trailblazing_sickle 1 (Self) 68 (Enemy+NPC)
6007 trailblazing_sickle_+1 1 (Self) 68 (Enemy+NPC)
11788 jesters_hat 1 (Self) 3 (Self+Party)
12408 absorbing_shield 20 (Enemy+Player) 4 (Enemy)
13182 oscar_scarf 20 (Enemy+Player) 4 (Enemy)
15175 revilers_helm 20 (Enemy+Player) 4 (Enemy)
15326 gargoyle_boots 0x101 (Self) 1 (Self)
15834 blind_ring 20 (Enemy+Player) 4 (Enemy)
16153 reikyo_hairpin 20 (Enemy+Player) 4 (Enemy)
16954 pealing_nagan 20 (Enemy+Player) 4 (Enemy)
17468 raise_rod 9 (Self+Alliance) 107 (Self+Party+Alliance+Corpse+NPC)
17469 raise_ii_rod 9 (Self+Alliance) 107 (Self+Party+Alliance+Corpse+NPC)
17470 pealing_buzdygan 20 (Enemy+Player) 4 (Enemy)
17583 kingdom_signet_staff 29 (Self+Enemy+Alliance+Player) 75 (Self+Party+Alliance+NPC)
17584 republic_signet_staff 29 (Self+Enemy+Alliance+Player) 75 (Self+Party+Alliance+NPC)
17585 federation_signet_staff 29 (Self+Enemy+Alliance+Player) 75 (Self+Party+Alliance+NPC)
17596 steel-splitter 20 (Enemy+Player) 4 (Enemy)
17625 ponderous_gully 20 (Enemy+Player) 4 (Enemy)
17703 pealing_anelace 20 (Enemy+Player) 4 (Enemy)
17949 furnace_tabarzin 20 (Enemy+Player) 4 (Enemy)
18060 blizzard_scythe 20 (Enemy+Player) 4 (Enemy)
18095 dispel_couse 20 (Enemy+Player) 4 (Enemy)
18107 ponderous_lance 20 (Enemy+Player) 4 (Enemy)
18225 blizzard_toporok 20 (Enemy+Player) 4 (Enemy)
18361 ponderous_manoples 20 (Enemy+Player) 4 (Enemy)
18399 charm_wand 4 (Enemy) 2 (Party)
18400 charm_wand_+1 4 (Enemy) 2 (Party)
18401 moogle_rod 4 (Enemy) 2 (Party)
18415 tojaku 20 (Enemy+Player) 4 (Enemy)
18679 soulgauger_sgr-1 20 (Enemy+Player) 4 (Enemy)
18721 soultrapper 20 (Enemy+Player) 4 (Enemy)
18724 soultrapper_2000 20 (Enemy+Player) 4 (Enemy)
18842 nomad_moogle_rod 4 (Enemy) 2 (Party)
18844 miracle_wand 4 (Enemy) 2 (Party)
18845 miracle_wand_+1 4 (Enemy) 2 (Party)
19204 fiendtrapper 20 (Enemy+Player) 4 (Enemy)

144bc22

Updates equipment entries with the proper:

  • Level/SuLvl/iLvl
  • Job mask
  • Slot
  • Shield Size

Noteworthy, beyond the formerly unimplemented items:

  • Wizard's rod loses BLU job
  • Sroda Tathlum: All Jobs -> BLM/RDM/SCH/GEO
  • Thrus Earring: WAR/PLD/DRK/BST/SAM/DRG
  • Srora earring: All Jobs -> BST/DRG/SMN/PUP
  • Crepuscular Ring Lv1 -> 99
  • Sroda Ring: All Jobs -> All but WHM/BLM/RDM/SCH/GEO
  • Seabirds Ring: Lv99 -> Lv30
  • Confectioner/Patissieres Ring: Lv99 -> Lv1
  • Gene Ring loses RUN
  • Gerdr Belt: All jobs -> All but WHM/BLM/RNG/SMN/PUP/SCH/GEO
  • Bunch of items were on the wrong slots entirely

370ef5e

Updates weapon entries with proper:

  • Skill type
  • Damage
  • Delay

Not much to talk about, everything was marked as not implemented except Wizard's Rod getting a better delay.

ea0859a

Updates damage type on a handful of weapons.

This part was done by hand after matching skill types to default damage type and then working through the exclusions.

Noteworthy:

  • Arrows get piercing damage to align on the rest (but this is cosmetic, the code doesnt care for it)
  • Vampirism and other Degen/Fleurets: Slashing -> Piercing
  • Camatlatia, Coalition Blade: Piercing -> Slashing
  • Malayo Crossbow +1: Slashing -> Piercing
  • Bunch of polearms: Slashing -> Piercing
  • Date Shuriken gets the appropriate subSkill matching other shurikens

Steps to test these changes

@Xaver-DaRed Xaver-DaRed merged commit 79bf2c6 into LandSandBoat:base Apr 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants