Skip to content

[core, sql] Flag certain items to skip treasure pool rare check and recycle bin#9763

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:treasure_no_rare_check
Apr 11, 2026
Merged

[core, sql] Flag certain items to skip treasure pool rare check and recycle bin#9763
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
sruon:treasure_no_rare_check

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 11, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Add NoRareCheck to chest and coffer keys
  • Modify treasure pool logic to allow items flagged as such to be added to the treasure pool even if everyone already owns one.
    • This does not apply to solo treasure pools
  • Add NoRecycle to Linkshell
  • Modify item drop packet to check for it and skip recycle bin if enabled

Steps to test these changes

In a party, give both players a Garlaige Chest key and then kill mobs in Garlaige until one is added to the pool.
With the key in pool, have P2 leave zone and chest key should be lost automatically on next tick.

@Xaver-DaRed Xaver-DaRed merged commit 1804d9b into LandSandBoat:base Apr 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants