Skip to content

[lua][chore] ROE Objective enums#9767

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
UmeboshiXI:ROE_Enums
Apr 12, 2026
Merged

[lua][chore] ROE Objective enums#9767
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
UmeboshiXI:ROE_Enums

Conversation

@UmeboshiXI
Copy link
Copy Markdown
Contributor

@UmeboshiXI UmeboshiXI commented Apr 12, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  1. Replaces all zone numbers with zone enums.

  2. Replaces usage of mobFamily with mobSuperFamily.

  • We will be reorganizing mob_family_system.sql so searching by the mob's super family rather than individual families will be more resilient to accidental breakage.
  • There were a couple entries that had TODO notes on whether subspecies were included or not (Search Cockatrice for an example). Most of the other similar objectives seemed to be including subspecies so I also changed these to use superFamily for now(I did leave the TODO notes though).

Steps to test these changes

  1. Flag a ROE objective, then attempt to complete it.

Note: I did not personally test all of these individually but the getSuperFamily() binding works as intended and everything else is just implementation of enums.

@Xaver-DaRed Xaver-DaRed merged commit 3488a59 into LandSandBoat:base Apr 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants