[Module] Quest "Chocobo's Wounds" - Era-Wait-Time

[JerokeXI]

[Module] Quest "Chocobo's Wounds" - Era Wait-Time

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

1. Modify the "Chocobo's Wounds" quest wait time between trades
   from 1 minute to wait for a new unique Vanadiel day.
   Proposal Co-Authored-By: Xaver-DaRed

• Makes the quest function like it did in Era prior to Feb. 2015 updates.

Steps to test these changes

1. Run command in map.exe: gm "player" 4 (5 if you're going to use !addtime)
2. Run the following GM commands in FFXI client

!setplayerlevel 20
!zone Upper Jeuno
!gotoname Brutus
!additem CLUMP_OF_GAUSEBIT_WILDGRASS x4

3. Talk to brutus and start the quest
4. Attempt to trade CLUMP_OF_GAUSEBIT_WILDGRASS to Chocobo every new in game day

• 1st, 2nd, and "too soon" attempts return appropriate dialogue
• Cutscene shows on 3rd attempt
• 3rd, 4th, 5th, and 6th attempts return appropriate dialogue and remove 1 grass from player

5. Quest completed with a cutscene and player received chocobo license

[CriticalXI]

An overall adjustment we should make too is that we should adjust this file to be a general quest adjustments file rather than being specifically for the Chocobo Wounds quest. Let's rename the file to "quest_adjustments.lua"

[CriticalXI]

Small nit but we should order these onEventFinish in numerical order.

[JerokeXI]

I will re-order this event to the bottom. Thank You.

[CriticalXI]

I think trying to module this quest is surfacing an issue we have with the tradeComplete. Looks like it currently doesn't take the item but it locks it in a weird state like we were talking about on Discord. This might require another PR to fix the trade binding so this npcUtil.giveItem isn't needed.

[Xaver-DaRed]

If one isnt completing/terminating a trade, One isnt supposed to use the tradeHasExactly() util.

And example of a trade that doesnt consume items but performs an action would be the beastcoin doors at Sea Serpent Grotto.

entity.onTrade = function(player, npc, trade)
    -- The coin isn't consumed, so we only need to know if one was in the trade window
    if trade:getItemQty(xi.item.GOLD_BEASTCOIN) > 0 then
        if player:getCharVar('SSG_GoldDoor') == 7 then
            npc:openDoor(5) -- Open the door if a gold beastcoin has been traded after checking the door the required number of times
        end
    end
end

This logic doesn't consude the item, nor changes it's state to reserved
trade:getItemQty(ITEM_ID) Should be used for those.

[JerokeXI]

I'll work changing the non-consuming events to use this function.

[claywar]

getVar always returns an int type.

[claywar]

Int type by default, no need to cast

[claywar]

Its a module, but magic numbers are never appreciated for future maintainers