Skip to content

[lua] Implement high/low pdif rolls for melee#9788

Merged
Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom
WinterSolstice8:pdif__lower_clamp
Apr 15, 2026
Merged

[lua] Implement high/low pdif rolls for melee#9788
Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom
WinterSolstice8:pdif__lower_clamp

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements the 50/50 high/low pdif selector for super low pdif values based on source cited in the code and word from Jimmayus (and other math nerds)

Fixes #9783

Steps to test these changes

Have ultra low pdif (1 attack vs 20k+ def mob), sometimes hit for non-zero with at ( weapon damage minus fstr) * .5 *1.05 and half of the time for zero

22 base damage weapon:
image

Comment thread scripts/globals/combat/physical_utilities.lua
Comment thread scripts/globals/combat/physical_utilities.lua
@Xaver-DaRed Xaver-DaRed merged commit d50a9b8 into LandSandBoat:base Apr 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Physical Damage Overflow Issue

2 participants