[lua] Implement high/low pdif rolls for melee#9788
Merged
Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom Apr 15, 2026
Merged
[lua] Implement high/low pdif rolls for melee#9788Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom
Xaver-DaRed merged 2 commits intoLandSandBoat:basefrom
Conversation
Xaver-DaRed
reviewed
Apr 14, 2026
8abd0ae to
c00dfde
Compare
c00dfde to
2ccf317
Compare
2ccf317 to
cad7d51
Compare
Xaver-DaRed
reviewed
Apr 14, 2026
3 tasks
Xaver-DaRed
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Implements the 50/50 high/low pdif selector for super low pdif values based on source cited in the code and word from Jimmayus (and other math nerds)
Fixes #9783
Steps to test these changes
Have ultra low pdif (1 attack vs 20k+ def mob), sometimes hit for non-zero with at ( weapon damage minus fstr) * .5 *1.05 and half of the time for zero
22 base damage weapon:
