[lua] Fix mobskill spam: Angler Orobon, Tinnin#9808
Merged
Conversation
Contributor
|
I dont think this is the proper fix. The action attempt should be discarded in core when the target isnt found, imo? |
Contributor
|
Its either that or add a target check every single time we use an skill by force |
Contributor
Author
It's not that the target isn't found, it's that the adjacent AoE targets aren't the mob's target. This change just ensures the additional code only runs one time. But, there could instead be a core change that makes this check before running onMobWeaponSkill. |
WinterSolstice8
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR resolves an issue with AoE or conal mobskills that trigger another useMobAbility(). If the initial mobskill hits multiple targets, then the secondary ability is queued multiple times.
Specifically this PR fixes only Tinnin and Angler Orobon, but there may be other instances. At a glance I didn't find any other obvious ones.
Steps to test these changes
Fight Tinnin with multiple characters, get hit by Barofield, see only one Polar Blast afterward.
Fight Angler Orobon (ISNM Compliments to the Chef) with multiple characters, get hit by Hypnic Lamp, see only one use of Deathgnash afterward.