Skip to content

[lua] Fix mobskill spam: Angler Orobon, Tinnin#9808

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
wccbuck:fix-mobability-spam
Apr 17, 2026
Merged

[lua] Fix mobskill spam: Angler Orobon, Tinnin#9808
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
wccbuck:fix-mobability-spam

Conversation

@wccbuck
Copy link
Copy Markdown
Contributor

@wccbuck wccbuck commented Apr 17, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR resolves an issue with AoE or conal mobskills that trigger another useMobAbility(). If the initial mobskill hits multiple targets, then the secondary ability is queued multiple times.

Specifically this PR fixes only Tinnin and Angler Orobon, but there may be other instances. At a glance I didn't find any other obvious ones.

Steps to test these changes

Fight Tinnin with multiple characters, get hit by Barofield, see only one Polar Blast afterward.
Fight Angler Orobon (ISNM Compliments to the Chef) with multiple characters, get hit by Hypnic Lamp, see only one use of Deathgnash afterward.

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

I dont think this is the proper fix. The action attempt should be discarded in core when the target isnt found, imo?

@Xaver-DaRed
Copy link
Copy Markdown
Contributor

Its either that or add a target check every single time we use an skill by force

@wccbuck
Copy link
Copy Markdown
Contributor Author

wccbuck commented Apr 17, 2026

I dont think this is the proper fix. The action attempt should be discarded in core when the target isnt found, imo?

It's not that the target isn't found, it's that the adjacent AoE targets aren't the mob's target. This change just ensures the additional code only runs one time.

But, there could instead be a core change that makes this check before running onMobWeaponSkill.

@Xaver-DaRed Xaver-DaRed merged commit dd1c8f1 into LandSandBoat:base Apr 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants