Skip to content

[core, lua] Execute *_TAKE listeners on all targets. Lower cleave stagger chance in Dynamis#9823

Merged
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
sruon:fix/aoe_take_listeners
Apr 20, 2026
Merged

[core, lua] Execute *_TAKE listeners on all targets. Lower cleave stagger chance in Dynamis#9823
Xaver-DaRed merged 2 commits into
LandSandBoat:basefrom
sruon:fix/aoe_take_listeners

Conversation

@sruon
Copy link
Copy Markdown
Contributor

@sruon sruon commented Apr 18, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closing a gap I've been aware of for a while: _TAKE listeners only execute for main targets presently.
This PR makes it so the listener is executed for all targets.

This enables cleave procs in Dynamis so I'm lowering the rate for subtargets from Magic 8%/JA 20%/WS 25% to 1%/2%/2%.
I've tried digging exact numbers but all that floats around is "significantly reduced" and I'm not willing to go capture 1000 procs myself right this minute.

Steps to test these changes

@Xaver-DaRed Xaver-DaRed merged commit 504c1f3 into LandSandBoat:base Apr 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants