[lua] Fix hybridDamage mobskill function#9824
Merged
Xaver-DaRed merged 1 commit intoApr 18, 2026
Merged
Conversation
Xaver-DaRed
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Overlooked this since I didn't have it hooked up to anything at the time of testing.
Fixes handleHybridDamage() function used for future hybrid bloodpacts/mobskills.
Steps to test these changes
Pick any physical mobskill script. Add the following:
-- params.hybridSkill = true
-- params.hybridSkillElement = xi.element.FIRE
-- params.hybridAttackType = xi.attackType.MAGICAL
-- params.hybridDamageType = xi.damageType.FIRE
execute that script on yourself using
!exec target:useMobAbility(skillID, player)on a mobTest Absorb or Nullification on yourself
!setmod FIRE_ABSORB 100or!setmod FIRE_NULLSee that NULL mod reduces to 0 and Absorb reduces damage of the skill (You usually won't be able to get it to do more damage than the primary physical damage and actually see the healing message)