Skip to content

[lua] Fix hybridDamage mobskill function#9824

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:fix_hybrid_mobskill_function
Apr 18, 2026
Merged

[lua] Fix hybridDamage mobskill function#9824
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:fix_hybrid_mobskill_function

Conversation

@UmeboshiXI
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Overlooked this since I didn't have it hooked up to anything at the time of testing.

Fixes handleHybridDamage() function used for future hybrid bloodpacts/mobskills.

Steps to test these changes

  1. Pick any physical mobskill script. Add the following:
    -- params.hybridSkill = true
    -- params.hybridSkillElement = xi.element.FIRE
    -- params.hybridAttackType = xi.attackType.MAGICAL
    -- params.hybridDamageType = xi.damageType.FIRE

  2. execute that script on yourself using !exec target:useMobAbility(skillID, player) on a mob

  3. Test Absorb or Nullification on yourself !setmod FIRE_ABSORB 100 or !setmod FIRE_NULL

  4. See that NULL mod reduces to 0 and Absorb reduces damage of the skill (You usually won't be able to get it to do more damage than the primary physical damage and actually see the healing message)

@Xaver-DaRed Xaver-DaRed merged commit 6c81838 into LandSandBoat:base Apr 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants